Improvements to linearization regression testing#2024
Improvements to linearization regression testing#2024andrew-platt merged 4 commits intoOpenFAST:dev-unstable-pointersfrom
Conversation
There is a bug in the AD15 linearization that is getting corrected in PR OpenFAST#2014
|
FYI @andrew-platt: Considering that you are eliminating low frequencies and keeping high frequencies, this should be called a high-pass filter rather than a low-pass filter. Such low frequencies reported by the eigensolution are likely ill-formed rigid body modes (whose frequency should be exactly zero, but are showing up slightly above zero due to, e.g., numerical round-off in the solution) or overly damped modes (when the post-processor computing the natural frequencies from the eigenvalues may not be working properly). Best regards, |
|
@jjonkman, that's a pretty idiotic mistake on my part. I was thinking I was suspicious there was something like that occurring with the low frequency modes. In the initial addition of the |
Started with name lowcut, then mistyped and never thought about it again. Definitely a blundering mistake from someone who has designed and built multiple low and high-pass electronic filters over the years (facepalm).
This ready to merge.
Feature or improvement description
Add two updates to the linearization regression testing method:
frequencies_ref.txtandfrequencies_new.txtFake5MW_AeroLin_B1_UA4_DBEMT3to fail when a frequency of ~0.00159 Hz - see below). The high-pass filter is set as an optional argument in theCTestList.cmakefile (i.e.of_regression_linear("Fake5MW_AeroLin_B1_UA4_DBEMT3" "-highpass=0.05" "openfast;linear;elastodyn;aerodyn"))Comparison tables
The new table format for the frequency comparisons appears as:
High-pass filter
Before adding the high-pass filter, the case
Fake5MW_AeroLin_B1_UA4_DBEMT3would fail with an extra low frequency value sometimes appearing at 0.001591549 Hz. For this case, this frequency doesn't make much sense. The high-pass filter allows us to ignore it.Related issue, if one exists
The
Fake5MW_AeroLin_B1_UA4_DBEMT3regression test was added at commit 202bfe7, then removed 2 months later with commit 8e7e0b9. Between these commits, no changes were made to anything related to linearization.This might be a candidate for inclusion in a v3.5.3 release.
NOTE: there is a bug in the AD15 linearization that is currently being fixed by PR #2014. So the
Fake5MW_AeroLin_B*cases are currently disabled even though they are the reason for this PR.Impacted areas of the software
Linearization.
Additional supporting information
Test results, if applicable
Test results do not change, but the comparison for linearization cases is slightly more robust.