HD Bug Fix for ExctnDisp and updates to CTestList.cmake with new r-tests#2031
Merged
andrew-platt merged 12 commits intoOpenFAST:dev-unstable-pointersfrom Mar 7, 2024
Merged
Conversation
Fixed the following problems: * HD driver seg fault when ExctnDisp=2 * Filtered WAMIT body position used in WAMIT_CalcOutput lags by one time step
…ctnDisp=1 and ExctnDisp=2 with ExctnMod=1
…wang/dev-unstable-pointers
…wang/dev-unstable-pointers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature or improvement description
A bug causing HydroDyn driver to crash when ExctnMod=2 is fixed along with a separate issue where the filtered potential-flow body position in WAMIT_CalcOutput is lagging one time step behind.
This PR also updates
CTestList.cmakewith new r-tests added through this PR.Related issue, if one exists
Related pull request to r-tests: OpenFAST/r-test#120
Impacted areas of the software
HydroDyn and regression tests.