Minor code cleanup#2078
Merged
andrew-platt merged 2 commits intoOpenFAST:dev-unstable-pointersfrom Mar 7, 2024
Merged
Conversation
- alphabetized ExternalInflow and ExtLoads modules (so they don't keep showing up as changes)
- `norm2` is not standard Fortran 2003, so produced warning on build.
andrew-platt
approved these changes
Mar 7, 2024
Collaborator
andrew-platt
left a comment
andrew-platt
left a comment
There was a problem hiding this comment.
Thanks for updating the vfproj file! We'll try not to rearrange it in future PRs.
Contributor
Author
When you renamed the OpFM module, it made sense to not move it to alphabetical order so we could see the differences easier. If only VS would stop randomly changing the order of the custom build section for the registry files... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature or improvement description
This PR removes some unused variables and replaces non-standard Fortran 2003 code with code that uses F03. I also saved the updated Visual Studio FASTlib project with the folders in alphabetical order to prevent it looking like there are differences every time you save the Visual Studio solution file to build OpenFAST.
Related issue, if one exists
none.
Test results, if applicable
There should be no changes to any results.