Skip to content

Remove linking of implicit Fortran libraries. #2138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrew-platt merged 2 commits into from
Apr 2, 2024
Merged

Remove linking of implicit Fortran libraries. #2138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e18dc41
Remove linking of implicit Fortran libraries.
jrood-nrel Apr 1, 2024
8ea0b9d
Docs: update changelog for PR #2138
andrew-platt Apr 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/changelogs/v3.5.3.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ Other notable improvements include corrections to turbine indexing when coupled
#2116 VSbuild: always build Registry as release x64 (@andrew-platt)
#2120 #2125 CMake: openmp optional for FF and CPP if not explicitly requested (@andrew-platt and @deslaughter)
#2128 VSbuild: set VS version to VS 2017 (@andrew-platt)
#2138 Remove linking of implicit Fortran libraries. (@jrood-nrel)


### Docker builds
Expand Down
1 change: 0 additions & 1 deletion modules/nwtc-library/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,6 @@ add_library(nwtclibs ${NWTC_SYS_FILE} ${NWTCLIBS_SOURCES})
target_link_libraries(nwtclibs PUBLIC
${LAPACK_LIBRARIES}
${CMAKE_DL_LIBS}
${CMAKE_Fortran_IMPLICIT_LINK_LIBRARIES}
)
if (USE_DLL_INTERFACE)
target_compile_definitions(nwtclibs PRIVATE USE_DLL_INTERFACE)
Expand Down