MAP: replace strncpy with strncpy_s

[andrew-platt]

Ready to merge (need someone with actual C knowledge to review it though).

Feature or improvement description
The intel c++ w_oneAPI_2021.1.1.99 compiler does not like the strncpy function and won't compile. Changing to strncpy_s.

Related issue, if one exists
See comment here: 93e2d27#r14664285 from PR #2394
Impacted areas of the software
Compilation of MAP with some compilers.

@sanguinariojoe, can you check this?

[andrew-platt]

Of course, changing to strncpy_s doesn't work with gcc... back to the drawing board I guess.

[bjonkman]

I had an issue with this a few days ago using the Visual Studio 2022 v143 C/C++ compiler. I added the _CRT_NONSTDC_NO_WARNINGS definition in the code when using MSVC:

openfast/modules/map/src/mapapi.h

Line 39 in 32ad558

#define _CRT_SECURE_NO_WARNINGS

but Visual Studio had also turned on the compiling option Additional Security Development Lifecycle (SDL) recommended checks, which made the warning an error. When I removed the \SDL option, it was able to build with the strncpy routine.

This may be helpful: https://stackoverflow.com/questions/22450423/how-to-use-crt-secure-no-warnings

[sanguinariojoe]

Microsoft is a truck load of shit... Anyway, I would say the smartest solution would be replacing the offending line --and the following one-- by:

size_t n = strnlen(input_txt_line, sizeof(init_type->library_input_str)) - 1; 
*((char *)memcpy(init_type->library_input_str, input_txt_line, n) + n) = '\0';

Checkout the critics of Ulrich Drepper to strlcpy.

I wrote that code directly here, on GitHub. It is not even tested.

[andrew-platt]

In trying out @deslaughter's suggestion, I discovered there is a MAP_STRCPY macro that already handles switching from strcpy and strcpy_s depending on compiler setup. Going to switch over to that instead -- will replace this PR with a PR from a new branch.

[andrew-platt]

Thanks @bjonkman for the workaround in VS. I think the new solution in #2420 is a bit simpler for end users, so we'll pursue that route.