Fix seg-fault for DBEMT_Mod=-1#2429
Merged
andrew-platt merged 2 commits intoOpenFAST:devfrom Sep 19, 2024
Merged
Conversation
deslaughter
approved these changes
Sep 19, 2024
bjonkman
approved these changes
Sep 19, 2024
Contributor
bjonkman
left a comment
bjonkman
left a comment
There was a problem hiding this comment.
Thanks for fixing this, @andrew-platt!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ready to merge
Feature or improvement description
A segmentation fault would occur if
DBEMT_Modwas set to-1. In PR #2427, I incorrectly assumed thatDBEMTshould be run ifDBEMT_Mod=-1. However, with the frozen wake, this should not be done.There were a few places where
if (p%DBEMT_Mod /= DBEMT_none)should have been updated toif (p%DBEMT_Mod > DBEMT_none). This fixes the issues we were seeing.Also note that this PR reverts commit 7305adb
Related issue, if one exists
#2427, see comment https://github.com/OpenFAST/openfast/pull/2427/files#r1765719295
Impacted areas of the software
AeroDyn with
DBEMT_Mod=-1