Bug: AeroDyn-Inflow WriteOutput Value Ordering#2457
Bug: AeroDyn-Inflow WriteOutput Value Ordering#2457andrew-platt merged 1 commit intoOpenFAST:devfrom
Conversation
andrew-platt
left a comment
There was a problem hiding this comment.
Looks good.
One modification you could do if you want.
|
This is interesting. The AeroDyn driver uses the headers that ADI assembles. I wonder why the AD driver assembles this array a second time instead of using this one from ADI. It was an issue in #2287. |
|
I knew this issue sounded familiar yesterday when were diagnosing it for ADI c-bindings -- I couldn't find the issue number at the time. The evolution of the driver and ADI library was convoluted with both @ebranlard and myself working on them. During the writing of the c-bindings library, I had duplicated some code that was in the driver. At that point we decided to collect some of the common pieces between the c-bindings and driver into the AeroDyn_Inflow.f90 library. However neither of us fully completed revisions in the driver or c-bindings (it ended up at the bottom of the list of code cleanup priorities to do when we have nothing else to do), so I'm not surprised that the driver is handling this differently than c-bindings. |
…pointer as the py_ad_* regression test references needed to change
c1cbbc2 to
0c870bd
Compare
This PR is ready to merge.
Feature or improvement description
This PR fixes a bug in the AeroDyn-Inflow library (
AeroDyn_Inflow.f90) where the order ofWriteOutputdid not matchWriteOutputHdrwhenInflowWindoutputs were requested.InflowWindoutputs were put at the end ofWriteOutput, but the header indicated thatInflowWindvalues should appear beforeAeroDynvalues.Impacted areas of the software
AeroDyn_Inflow.f90Additional supporting information
This issue only occurs when using AeroDyn-Inflow directly or AeroDyn-Inflow C Bindings when outputs have been requested from InflowWind and AeroDyn. The AeroDyn Driver output is not affected as that program assembles its output array directly.