SD: Bug fix for concentrated mass with CoG offset#2458
Merged
andrew-platt merged 2 commits intoOpenFAST:devfrom Oct 21, 2024
Merged
SD: Bug fix for concentrated mass with CoG offset#2458andrew-platt merged 2 commits intoOpenFAST:devfrom
andrew-platt merged 2 commits intoOpenFAST:devfrom
Conversation
…c stiffness from cable pretension
Collaborator
|
@RBergua, can you run a test of this? |
jjonkman
approved these changes
Oct 17, 2024
Collaborator
jjonkman
left a comment
There was a problem hiding this comment.
I agree with the changes being implemented. Please merge once you are happy with the tests.
Contributor
|
I took advantage of the system documented here: #2021, defined two lumped masses at (0, 0, 0) and defined two eccentricities. I'm able to get the same results as using the rigid link + lumped mass workaround. So, everything looks alright to me. Maybe I would clarify in the documentation that when defining an eccentricity, the moments of inertia that the user provides are around the center of mass. |
andrew-platt
approved these changes
Oct 21, 2024
This was referenced Dec 24, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR should be ready to merge after review.
Feature or improvement description
This PR aims to fix a known bug with non-zero CoG offset/eccentricity of concentrated masses in SubDyn (Issue #1710) that was causing problems for some users (Issue #2451). The following fixes are implemented:
p%FGfollowing the suggested fix of @ebranlard in Issue SD: concentrated mass with excentricity cannot be fully accounted for in SubDyn #1710.p%CMassNode.p%CMassWeight, andp%CMassOffsetto supportGuyanLoadCorrectionfor fixed-bottom structures and self-weight update for floating structures during the run.GuyanLoadCorrectionterm to the nodal moments is added. This term is in the form ofcross_product( matmul(p%CMassOffset(i,:),orientation)-p%CMassOffset(i,:), (/0.0,0.0,-p%CMassWeight(i)/) ), whereorientationis just the nodal orientation matrix due to the Guyan modes only. This additional correction term is zero if the offset/eccentricity is zero as expected.This PR also adds a warning that SubDyn currently does not account for geometric stiffness from cable pretension if the user specifies one or more cables with non-zero pretension. See Issue #1956 and PR #2363.
Related issue, if one exists
Issues #1710, #2451, #1956
Impacted areas of the software
SubDyn
Test results, if applicable