Use B4Ki to store array bounds during pack/restore of TurbineType to file#2519
Merged
deslaughter merged 6 commits intoOpenFAST:devfrom Nov 16, 2024
Merged
Conversation
…n the wrong order.
andrew-platt
approved these changes
Nov 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is ready to merge.
Feature or improvement description
Changes were made to the
openfast-registryandModRegGen.pyto useB4Kiinteger for storing array bounds when saving and restoring turbines to/from a file. This was necessary because the ROCm Flang compiler doesn't supportlboundanduboundreturningB8Kiintegers in violation of the Fortran standard.Impacted areas of the software
The main changes are in
openfast-registryandModRegGen.pyto change the type on the array bounds. However, this change requires regenerating all of the*_Types.f90files which results in a huge number of lines changed.Additional supporting information
This branch has been tested and verified to work on the Frontier supercomputer where the issue was occurring.