Conversation
Ideally, we would set this after we initialize AD and decide based on if OLAF is used. But IfW is initialized before AD now, so we don't know if OLAF will need this info.
deslaughter
approved these changes
Dec 23, 2024
mayankchetan
approved these changes
Dec 23, 2024
Contributor
mayankchetan
left a comment
mayankchetan
left a comment
There was a problem hiding this comment.
Looks good to me! thank you Andy!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ready to merge
Feature or improvement description
If OLAF is used, the wakes may move out of bounds of the wind box (i.e. TurbSim .bts format). When this happens, wind for OLAF points outside the box should be extrapolated beyond the box as described here: https://openfast.readthedocs.io/en/dev/source/user/inflowwind/driver.html#boxexceedallow-flag.
In both the AeroDyn_Driver and in OpenFAST, the InflowWind module is initialized before AeroDyn so we don't know at that time if OLAF will be used. This PR sets the
BoxExceedAllowflag if AD is used in either context, which can be a computational waste if OLAF is not used. Ideally we would initialize the data structure for the extrapolation the first time it is accessed to avoid the unnecessary computation ahead of time if it isn't needed.Related issue, if one exists
#2518
#1748
#1516
This particular issue was reported in a conversation outside of GH.
Impacted areas of the software
AeroDyn only
Additional supporting information
Test results, if applicable
No results change with this case -- we don't run an OLAF cases with turbulent wind flow for long in enough to see this issue in the regression testing.