Add job to build Windows executables to deploy.yml#2636
Merged
deslaughter merged 35 commits intoOpenFAST:devfrom Feb 14, 2025
Merged
Add job to build Windows executables to deploy.yml#2636deslaughter merged 35 commits intoOpenFAST:devfrom
deslaughter merged 35 commits intoOpenFAST:devfrom
Conversation
andrew-platt
approved these changes
Feb 13, 2025
Collaborator
andrew-platt
left a comment
andrew-platt
left a comment
There was a problem hiding this comment.
this is fantastic! It will really speed up our builds at release.
…spatch. PR is ready.
andrew-platt
approved these changes
Feb 14, 2025
Collaborator
andrew-platt
left a comment
andrew-platt
left a comment
There was a problem hiding this comment.
Looks good enough for now :) Let's see what it does on the next release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is ready merge.
Feature or improvement description
This PR adds a job to the GitHub CI (
deploy.yml) which will automatically build the full suite of Windows executables from thevs-builddirectory on release. This workflow can also be run manually which will allow for spot checking of the Visual Studio build without needing to build locally.Impacted areas of the software
deploy.ymlGitHub CIAdditional supporting information
This build uses the
ifortcompiler and Visual Studio. Once theifxcompiler is fully vetted, the build can switch to it. Until then, the build output will show warnings about the depreciation ofifort.