bug fix: Adjust steady-state solver small angle assumptions#2760
Merged
andrew-platt merged 1 commit intoOpenFAST:devfrom Apr 24, 2025
Merged
bug fix: Adjust steady-state solver small angle assumptions#2760andrew-platt merged 1 commit intoOpenFAST:devfrom
andrew-platt merged 1 commit intoOpenFAST:devfrom
Conversation
was using log maps in the steady-state solver for differencing, but the perturbation function assumed they were angles when it adjusted them later
Collaborator
|
Potentially backport to a 4.0.4 (if we do one) |
deslaughter
approved these changes
Apr 24, 2025
Collaborator
deslaughter
left a comment
deslaughter
left a comment
There was a problem hiding this comment.
Thanks for putting this together!
andrew-platt
approved these changes
Apr 24, 2025
andrew-platt
added a commit
that referenced
this pull request
Apr 25, 2025
backport of #2760: bug-fix: Adjust steady-state solver small angle assumptions
|
great |
This was referenced Jun 16, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature or improvement description
This PR fixes the AeroMap solver's perturbations of orientation matrices. It was using log maps, but other parts of the code had been changed to no longer use log maps, potentially causing differences, particularly with angles farther from 0.
Related issue, if one exists
Impacted areas of the software
This affects AeroMaps only.
Test results, if applicable
This does not change existing regression tests.