ElastoDyn: Allow one-blade turbine model#589
Conversation
56cc8c8 to
ba7c86a
Compare
|
Thanks, @ebranlard. These ElastoDyn changes all make sense to me. I'm a bit concerned that there are likely necessary changes outside of ElastoDyn that require changes as well (given that NumBl is an initialization output of ElastoDyn for use by AeroDyn, ServoDyn, and the C++ interface). Did you check these modules for any necessary changes as well? |
|
Thanks for the review. I haven't seen any issue with AeroDyn, apart from hard coded number of blade inputs in the input file (3 blade files), but only then. The same is found for ServoDyn, where most of the I've tested this with AeroDyn and ServoDyn for 1,2 and 3 blades, and the results seemed to make sense. I wouldn't be surprised if there is a corner case that I've missed, but we can hopefully easily spot and fix such array bound. Hopefully the r-test will pass.. |
jjonkman
left a comment
There was a problem hiding this comment.
Sounds good. I'll approve.
|
@ebranlard Do you have 1-blade test case? |
|
I don't really have a test (I mostly did this to have only one blade for the elliptical wing of OLAF, which is "inelastic"). An easy and more or less relevant one would be to simply duplicate this one, and changing the number of blade to 1 in ElastoDyn input file (that will affect AeroDyn and ServoDyn): |
|
The test case for this will be added in PR #648. |
Ready to be merged.
Feature or improvement description
Allows
NumBld=1in ElastoDynImpacted areas of the software
ElastoDyn
Additional supporting information
The only changes needed from what I could see were about disactivating some output channels. The total number of DOF being reduced, if statements that relied on the Teeter DOF being at position 22 needed to be changed since this index is out of bounds for a 1 bladed rotor (max number of DOF being 18).
Extending to more blades (>3) would require a rework of the outputs and the DOF indexing.