Preliminary support for multiple rotors in AeroDyn#672
Merged
andrew-platt merged 6 commits intoOpenFAST:devfrom Mar 19, 2021
Merged
Preliminary support for multiple rotors in AeroDyn#672andrew-platt merged 6 commits intoOpenFAST:devfrom
andrew-platt merged 6 commits intoOpenFAST:devfrom
Conversation
Contributor
Author
|
@bjonkman if you have time, can you have a look at these code changes? Thanks a lot! |
8 tasks
andrew-platt
approved these changes
Mar 19, 2021
Collaborator
andrew-platt
left a comment
There was a problem hiding this comment.
I looked through quickly and didn't see anything problematic.
The glue code changes look ok.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is ready to merge
Feature or improvement description
Provide support for multiple rotors in AeroDyn.
This feature is not yet supported by the glue-code, nor the current aerodyn-driver, but it has been tested using a new aerodyn driver that will be shipped in a future pull request. This is an example of VTK outputs with the new driver, both rotors are handled by BEM:
Actions:
Impacted areas of the software
AeroDyn, OpenFAST library, Openfoam coupling
Additional supporting information
General info:
%rotors(1)in the glue code and other caller of AeroDyn.Some points to review/comment on:
AirDensity,BEM Options, this offer the most flexibility, but might be overkill (say one rotor in the water and one in the air, one with UA the other without). I can easily change this, most AeroDyn functions now have two set of parameters coming in,p(the rotor parameters), andp_AD` the AeroDyn parameters (very few for now, but we can shift AirDensity there for instance).WriteOutputsdirectly, and I had to add an if statement in the glue code at the point where the write outputs from each modules are packed.AD_RoutineName->RotRoutineNamefor routines that are rotor specific. The code will return an error if linearization is done for multiple rotors.%rotorswith%rotfor shorter notations