Fix some memory leaks in FAST.Farm#860
Merged
andrew-platt merged 1 commit intoOpenFAST:devfrom Oct 7, 2021
Merged
Conversation
1. AWAE_End was never called, so some memory wasn't getting deallocated from InflowWind 2. Many of the "farm" variables were not deallocated 3. I made the OutList(:) array in FAST.Farm a fixed size instead of allocatable. It was getting allocated to a fixed size (set by parameter) anyway.
jjonkman
approved these changes
Oct 7, 2021
Collaborator
jjonkman
left a comment
jjonkman
left a comment
There was a problem hiding this comment.
Looks good to me; thanks!
Codecov Report
@@ Coverage Diff @@
## dev #860 +/- ##
=======================================
Coverage 11.27% 11.27%
=======================================
Files 211 211
Lines 309733 309733
Branches 180530 180530
=======================================
Hits 34910 34910
Misses 230900 230900
Partials 43923 43923
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is ready to merge.
Feature or improvement description
I modified FAST_Farm_Subs.f90 to avoid some memory leaks. These changes should not affect any results.
Related issue, if one exists
These issues were found in #784, but may or may not have solved the underlying problem there.
Impacted areas of the software
FAST.Farm