refactor: templateFiles as dict instead of individual parameters insetTemplateFilename#36
Merged
rthedin merged 3 commits intoOpenFAST:mainfrom Feb 27, 2025
Merged
Conversation
Contributor
Author
Reverting back several changes that were made incorrectly. Lots of checks were simply deleted, tempates given as filepaths were replaced incorrectly with filename, among a few other things. Overall the proposed logic of having a dictionary was kept.
Collaborator
|
Lots of changes made to make sure the proposed changes are in line with what was already in the code. Unfortunately with the refactor, several checks and details were deleted and had to be restored. Additional checks on the input dictionary has been put in place too. |
Collaborator
|
This is good to go. Thanks for the contribution, @ombahiwal. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
from list of issues #17
Changes:
setTemplateFilenamenow takes a singletemplateFilesdictionary as an argument, where keys are the names of the expected filenames (like EDfilename, SEDfilename, etc.) and values are the actual filenames (e.g., 'EDtemplate', 'SEDtemplate', etc.).templateFilesdict. For each key-value pair, it processes the file similarly to how it did for individual parameters before, checking the filename extension and constructing the file path.