Migrate to maven move to org io.github.openfeign#404
Closed
spencergibb wants to merge 10 commits intoOpenFeign:masterfrom
Closed
Migrate to maven move to org io.github.openfeign#404spencergibb wants to merge 10 commits intoOpenFeign:masterfrom
spencergibb wants to merge 10 commits intoOpenFeign:masterfrom
Conversation
Contributor
Author
|
Still missing any publishing framework, but we could adapt what is done for openzipkin. |
Contributor
|
Why is it "feigntown"? (It's just hard to remember.) |
Contributor
Author
|
@dsyer feign is taken. Open to suggestions. OpenFeign? |
Contributor
Author
|
See #373 for adrian's suggestion. |
spencergibb
changed the title
Contributor
|
We should probably migrate this to the new org before merging this. before that, we need sonatype etc setup. |
| server.start(); | ||
| client = new OkHttpClient(); | ||
| client.setRetryOnConnectionFailure(false); | ||
| // FIXME openfeign client.setRetryOnConnectionFailure(false); |
Contributor
Author
There was a problem hiding this comment.
setRetryOnConnectionFailure doesn't exist on okhttp3.OkHttpClient.
Closed
Contributor
|
closed via #416 thanks for the help! |
Merged
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/cc @adriancole for your perusing pleasure :-)