Switching to TYK2 as example system throughout the showcase notebook #117
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
|
|
View / edit / reply to this conversation on ReviewNB IAlibay commented on 2024-03-11T10:00:02Z [enhancement]
A Pymol render of the protein would be amazing here. hannahbaumann commented on 2024-03-25T13:45:33Z Added an image, if this will be our main advertising notebook, maybe Ben could make a prettier one, but maybe for right now this is also ok? IAlibay commented on 2024-04-03T09:28:44Z Let's go with this one for now. |
|
View / edit / reply to this conversation on ReviewNB IAlibay commented on 2024-03-11T10:00:03Z Wasn't this used as part of one of the tutorials at last year's OMSF workshop? It feels like a reasonably useful command - do we have an issue anywhere that aims to remove it? (or conversely add it to the help info?) hannahbaumann commented on 2024-03-25T13:47:45Z We should discuss this, if the plan is to use this command (it generally seems useful), we should expose it in the CLI, if we decide not to expose it there we shouldn't advertise it here, I think (you currently can't find this command with IAlibay commented on 2024-04-03T09:49:29Z I've raised an issue, it doesn't seem like removing it from help was advertised anywhere (it used to be there) IAlibay commented on 2024-04-04T08:02:24Z Based on the issue - let's go ahead and remove it. hannahbaumann commented on 2024-04-11T12:00:28Z I remove it!
|
|
View / edit / reply to this conversation on ReviewNB IAlibay commented on 2024-03-11T10:00:03Z There's some reference to T4 lysozyme here that should be swaped to TYK2 under points 1 and 2. hannahbaumann commented on 2024-03-25T13:48:05Z Thanks, changed this! |
|
View / edit / reply to this conversation on ReviewNB IAlibay commented on 2024-03-11T10:00:04Z These probably need updating - just manually editing the metadata would be best. Otherwise folks will run the notebook and get drastically different values and wonder what's going on. hannahbaumann commented on 2024-03-25T13:49:46Z Removed the cell output (for now since this is just a first stab at this) |
IAlibay
left a comment
IAlibay
left a comment
There was a problem hiding this comment.
Thanks @hannahbaumann ! Here's a couple of review comments - as usual the [enhancement] tag is very much optional.
|
Added an image, if this will be our main advertising notebook, maybe Ben could make a prettier one, but maybe for right now this is also ok? View entire conversation on ReviewNB |
|
We should discuss this, if the plan is to use this command (it generally seems useful), we should expose it in the CLI, if we decide not to expose it there we shouldn't advertise it here, I think (you currently can't find this command with View entire conversation on ReviewNB |
|
Thanks, changed this! View entire conversation on ReviewNB |
|
Removed the cell output View entire conversation on ReviewNB |
|
Let's go with this one for now. View entire conversation on ReviewNB |
|
I've raised an issue, it doesn't seem like removing it from help was advertised anywhere (it used to be there) View entire conversation on ReviewNB |
|
Based on the issue - let's go ahead and remove it. View entire conversation on ReviewNB |
|
I remove it!
View entire conversation on ReviewNB |
No description provided.