Update cookbooks for openfe 1.0 #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
|
| { | ||
| "cells": [ | ||
| { | ||
| "cell_type": "markdown", |
Contributor
There was a problem hiding this comment.
Line #33. off_toolkit_backend='ambertools', # Toolkit to use for partial charge assignment - ambertools
Reply via ReviewNB
| { | ||
| "cells": [ | ||
| { | ||
| "cell_type": "markdown", |
Contributor
There was a problem hiding this comment.
Line #51. # False: don't apply excplicit charge correction using an alchemical water Line #51. # False: don't apply explicit charge correction using an alchemical water
Reply via ReviewNB
Contributor
hannahbaumann
left a comment
hannahbaumann
left a comment
There was a problem hiding this comment.
Two small spelling things, otherwise lgtm! I haven't tried and run it myself, please let me know if that would be helpful!
Member
Author
|
Thanks @hannahbaumann ! I added the two typo fixes. |
Member
Author
I don't think it's necessary, but if you feel like it more checks doesn't hurt either. |
hannahbaumann
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #118
Fixes coobooks for 1.0rc