-
Notifications
You must be signed in to change notification settings - Fork 10
Fix old showcase for 1.0 release #128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
This PR just fixes the notebook to work with openfe 1.0 (settings, mapping), otherwise this is still the same old notebook. This is to be replaced by the new notebook soon. |
|
The two notebooks that are failing here have been fixed in PR #99 |
|
If I understand this PR correctly @richardjgowers @hannahbaumann the point is to just get the notebook we are using for http://try.openfree.energy/ to work with openfe 1.0 |
|
@richardjgowers This is ready to merge! |
|
Also thanks Hannah for fixing the API changes! |
|
we had 2 notebooks still failing on CI as @hannahbaumann noted, I pulled in changes from #99 by hand to fix those two notebooks, assuming CI passes (at least on linux), I will get this merged in! |

No description provided.