Skip to content

Conversation

@atravitz
Copy link
Contributor

to stay consistent with openfe: OpenFreeEnergy/openfe#1121

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch OpenFreeEnergy/ExampleNotebooks/remove_easy_prefix

@atravitz atravitz marked this pull request as draft February 11, 2025 18:01
@atravitz atravitz self-assigned this Feb 19, 2025
@atravitz atravitz marked this pull request as ready for review February 19, 2025 17:59
@atravitz atravitz requested a review from mikemhenry February 19, 2025 17:59
@atravitz
Copy link
Contributor Author

cookbooks/create_alchemical_network.ipynb is failing because of gufe also using easy_ prefixes: https://github.com/OpenFreeEnergy/gufe/blob/f1779a5a6e920fa40d73acdd227a0d90168d2b30/gufe/ligandnetwork.py#L316

changing just this cookbook back to having the easy_ prefix, but I'd like to remove it on the gufe side as well...

Copy link
Contributor

@mikemhenry mikemhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good catch on updating to use the 1.3 release

@mikemhenry mikemhenry merged commit a64002e into main Feb 20, 2025
4 checks passed
@mikemhenry mikemhenry deleted the remove_easy_prefix branch February 20, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants