-
Notifications
You must be signed in to change notification settings - Fork 10
Add a SepTop RBFE tutorial #202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
I'm currently creating the network using an atom mapper which may be confusing. I could instead either do a star map, looping over the |
|
I think doing it with network planning is fine, just have a bolded note that says that the mapping isn't used outside of the score. Alternatively manually specifying edges is also fine IMHO. |
| @@ -0,0 +1,588 @@ | |||
| { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're doing this here for SepTop but not for ABFE. Not sure if intentional but just checking.
Reply via ReviewNB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes, I had used different templates for the two notebooks. Should I add this to the ABFE notebook?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Long term I think the idea would be to replace this with a "our ligands are pre-charged, see this cookbook here for an example of how you can go about charging your ligands".
Probably best to just add this into ABFEs for now and fix both the notebooks later to match whenever we're ready to make the change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good!
| @@ -0,0 +1,595 @@ | |||
| { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the paper I'm only showing the complex leg in detail, I thought that might be confusing here, and that it would be better to just show the simple full cycle. But I can also change it to the figure from the paper!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fair, this works for me if it works for you.
No description provided.