Skip to content

Conversation

@hannahbaumann
Copy link
Contributor

No description provided.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch OpenFreeEnergy/ExampleNotebooks/abfe-tutorial

@hannahbaumann
Copy link
Contributor Author

It may make sense to remove the section on python API execution and analysis as people shouldn't run this in this notebook. What do others think?

@hannahbaumann
Copy link
Contributor Author

hannahbaumann commented Apr 24, 2025

ToDo:

  • Run the example simulation and deposit the output json here.

@IAlibay
Copy link
Member

IAlibay commented Apr 24, 2025

It may make sense to remove the section on python API execution and analysis as people shouldn't run this in this notebook. What do others think?

I'd keep the cell but maybe just comment it out and add some context?

@hannahbaumann hannahbaumann requested a review from jthorton April 24, 2025 14:00
Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of things, otherwise lgtm!

Copy link
Contributor

@jthorton jthorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, looks great!

@hannahbaumann hannahbaumann merged commit e7fb5c8 into main Apr 29, 2025
2 of 4 checks passed
@hannahbaumann hannahbaumann deleted the abfe-tutorial branch April 29, 2025 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants