Skip to content

Conversation

@mikemhenry
Copy link
Contributor

No description provided.

@mikemhenry mikemhenry marked this pull request as draft October 30, 2025 19:14
@github-actions
Copy link

Colab 👈 Launch a Colab session on branch feat/build-openfe-docs

@mikemhenry
Copy link
Contributor Author

Okay so this works!
https://github.com/OpenFreeEnergy/ExampleNotebooks/actions/runs/18952836239/job/54121759524

I now want to make a change to a notebook in this PR and make sure that it will catch a mistake

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@mikemhenry
Copy link
Contributor Author

sweet, it worked!

/home/runner/work/ExampleNotebooks/ExampleNotebooks/openfe/docs/tutorials/septop_tutorial.nblink:29: ERROR: Error in "image" directive:
invalid option value: (option: "width"; value: '600/')
not a positive measure of one of the following units:
"em" "ex" "px" "in" "cm" "mm" "pt" "pc" "%".

I will undo that and then this will be ready for review

@mikemhenry mikemhenry marked this pull request as ready for review October 30, 2025 19:49
@mikemhenry mikemhenry requested a review from atravitz October 30, 2025 19:49
Copy link
Contributor

@atravitz atravitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fantastic, thanks @mikemhenry !

@atravitz atravitz merged commit 9dff0fa into main Oct 30, 2025
2 of 5 checks passed
@atravitz atravitz deleted the feat/build-openfe-docs branch October 30, 2025 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants