Skip to content

Conversation

@RiesBen
Copy link
Contributor

@RiesBen RiesBen commented Nov 22, 2023

No description provided.

@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch OpenFreeEnergy/ExampleNotebooks/tutorial_add_settings_cli

@RiesBen RiesBen changed the title [WIP] Add information about the settings flag to cli tutorial. Add information about the settings flag to cli tutorial. Nov 26, 2023
@RiesBen RiesBen requested review from IAlibay, dwhswenson and richardjgowers and removed request for dwhswenson November 26, 2023 09:25
Copy link
Member

@dwhswenson dwhswenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need a more general refactoring of docs, but for now, could this be moved to a separate file, which is linked in a single-sentence from here? The goal is to make the initial tutorial look absolutely trivial so that new users see that the easiest cases are very easy, but then let users learn layers of complexity over time.

TBH, it probably makes more sense to just put this content in OpenFE docs, as opposed to in this repo (a statement which might also apply to the entire tutorial).

@richardjgowers
Copy link
Contributor

@dwhswenson I think we should be linking to a (currently nonexistant) page in the docs that lists all possibilities from the cli, but I think a quick example that the CLI is extensible via these yaml files isn't making the CLI tutorial overly long

@dwhswenson
Copy link
Member

@richardjgowers : This content represents more than 1/5 of the total tutorial. It is a significant increase.

Also, I think we should pay attention to advice from diataxis. (We're far from perfect at that, but we should try to be better.) Specific to this point: https://diataxis.fr/tutorials/#ignore-options-and-alternatives

@RiesBen RiesBen self-assigned this Jan 9, 2024
@RiesBen RiesBen added the documentation Improvements or additions to documentation label Jan 9, 2024
@RiesBen
Copy link
Contributor Author

RiesBen commented Jan 9, 2024

@dwhswenson & @richardjgowers :

Roadmap 🚝 regarding changes 🔧 to this PR will be:

could you please give me quick feedback on the .ipynb page location? (that's a bit of work for me and it would be grande if we could agree on one location ☺️)

@dwhswenson
Copy link
Member

@RiesBen : Could you give a little more picture of what you're planning for the notebook?

At first guess, it sounds like this is something that belongs in the cookbooks/ directory, and which should also be brought into the core OpenFE documentation.

TBH, notebooks that only exist in this repository without a link in the core docs are probably not what we want. We should be pushing users to https://docs.openfree.energy; the fact that the source is in here is just so we don't bloat the core OpenFE repo.

@RiesBen
Copy link
Contributor Author

RiesBen commented Jan 12, 2024

@dwhswenson :
general idea was to give a quick guide on how to customize the setup procedure for RFE approaches (Network algorithm, mapper etc.)

If I extract the block from the current jnb, I either can put it in an minimal example .jnb (in cookbook?) or make some rest text file out of it. depending on how we want to do this. I think best we have a quick chat about this on monday.

@richardjgowers richardjgowers merged commit 0f02fff into main Jan 31, 2024
@richardjgowers richardjgowers deleted the tutorial_add_settings_cli branch January 31, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docs: write CLI-Turorial -> Kartograf in OpenFE

4 participants