-
Notifications
You must be signed in to change notification settings - Fork 10
[WIP] Adding tutorial for building AlchemicalNetworks for consumption with fah-alchemy
#46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… with `fah-alchemy` This PR adds the sphinx doc skeleton, along with our first tutorial. The scope of this tutorial should be AlchemicalNetwork creation, up to submission using the `FahAlchemyClient`.
|
Would like to use a real |
Codecov ReportBase: 81.24% // Head: 79.08% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #46 +/- ##
==========================================
- Coverage 81.24% 79.08% -2.17%
==========================================
Files 19 19
Lines 965 1023 +58
==========================================
+ Hits 784 809 +25
- Misses 181 214 +33
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
I did a run-through of this draft, some quick comments. They are mostly
|
Just a point on this, these are current available under openfe (including an upcoming py3dmol based one), and I think we came to the conclusion that we didn't think pulling the necessary dependencies should be in gufe. I'm not sure if moving them makes sense, probably worth discussing. |
|
Per discussion with @IAlibay, may make sense to migrate this tutorial to |
|
@richardjgowers will take over this PR, migrate to |
|
Would people be okay if I split the sphinx docs setup for FAH off this PR? I might do that now so I can work on some of the docs? |
|
@hmacdope yes please! Go for it! |
|
I'll create a PR into |
|
Will instead make a PR into openfreeenergy/ExampleNotebooks. |
This was originally created for [`alchemiscale`](OpenFreeEnergy/alchemiscale#46), but is being contributed here instead, since it really is a `gufe` tutorial.
|
Superseded by OpenFreeEnergy/ExampleNotebooks#36 |
This PR adds the sphinx doc skeleton, along with our first tutorial. The
scope of this tutorial should be AlchemicalNetwork creation, up to
submission using the
FahAlchemyClient.