-
Notifications
You must be signed in to change notification settings - Fork 14
0.5.0 release prep #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.5.0 release prep #135
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
IAlibay
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are other changes that need documenting.
IAlibay
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Key things that have changed that need documenting here are #112, #113, #114.
I should note that I'm not sure if behaviour has significantly changed. Definitely graph is no longer a public attribute of FEMap, I don't think many folks were using it, but we should be sure it doesn't impact our stack at least.
Co-authored-by: Mike Henry <11765982+mikemhenry@users.noreply.github.com>
mikemhenry
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM -- Just one typo
|
You can merge this in after the typo fix |
IAlibay
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just the one question.
This reverts commit 7e20dee.
Co-authored-by: Mike Henry <11765982+mikemhenry@users.noreply.github.com>
…ar into release_prep_0.5.0
| target_name : string, optional | ||
| name of system for results, e.g. 'Thrombin' | ||
| quantity : str, default = '$\Delta \Delta$ G' | ||
| quantity : str, default = '$\\Delta \\Delta$ G' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dislike this, but I dislike our readthedocs builds breaking even more. this code doesn't even get rendered in our docs.
cb917e6 to
2c237a6
Compare
No description provided.