Skip to content

Conversation

@atravitz
Copy link
Collaborator

No description provided.

@atravitz atravitz requested a review from mikemhenry June 16, 2025 15:52
@codecov
Copy link

codecov bot commented Jun 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.95%. Comparing base (fee3e70) to head (b63be8f).
⚠️ Report is 47 commits behind head on main.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are other changes that need documenting.

Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Key things that have changed that need documenting here are #112, #113, #114.

I should note that I'm not sure if behaviour has significantly changed. Definitely graph is no longer a public attribute of FEMap, I don't think many folks were using it, but we should be sure it doesn't impact our stack at least.

atravitz and others added 2 commits June 16, 2025 12:35
Co-authored-by: Mike Henry <11765982+mikemhenry@users.noreply.github.com>
@atravitz atravitz requested review from IAlibay and mikemhenry June 16, 2025 20:30
Copy link
Collaborator

@mikemhenry mikemhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- Just one typo

@mikemhenry
Copy link
Collaborator

You can merge this in after the typo fix

Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just the one question.

atravitz and others added 3 commits June 16, 2025 13:54
This reverts commit 7e20dee.
Co-authored-by: Mike Henry <11765982+mikemhenry@users.noreply.github.com>
@mikemhenry mikemhenry self-requested a review June 16, 2025 20:59
target_name : string, optional
name of system for results, e.g. 'Thrombin'
quantity : str, default = '$\Delta \Delta$ G'
quantity : str, default = '$\\Delta \\Delta$ G'
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dislike this, but I dislike our readthedocs builds breaking even more. this code doesn't even get rendered in our docs.

@atravitz atravitz force-pushed the release_prep_0.5.0 branch from cb917e6 to 2c237a6 Compare June 16, 2025 21:47
@atravitz atravitz merged commit ed949b9 into main Jun 16, 2025
8 checks passed
@atravitz atravitz deleted the release_prep_0.5.0 branch June 16, 2025 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants