Fix #37: Fix erroneous MLE estimate when self-edges are included #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…energies if a self-edge is added, and watch it fail
ijpulidos
approved these changes
Jan 10, 2022
Collaborator
ijpulidos
left a comment
ijpulidos
left a comment
There was a problem hiding this comment.
Nice catch. I have some non-blocking comments, but this should be merged as it is.
Comment on lines
+217
to
+219
| if i == j: | ||
| # The MLE solver will fail if we include self-edges, so we need to omit these | ||
| continue |
Collaborator
There was a problem hiding this comment.
Nice catch! This looks good. Just thinking that the loops in lines 193 and 214 could be merged (should increase performance). But that would also require that the loop in line 210 to happen before. It's probably a small increase in performance but thought it should be mentioned. Non-blocking.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes issue #37 (Graphs containing self-edges will produce erroneous MLE estimates), and adds a test that failed prior to the fix to verify the issue is resolved.
Status