Skip to content

[WIP] Fix CI and badges #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
richardjgowers merged 3 commits into from
May 17, 2022
Merged

[WIP] Fix CI and badges #58

richardjgowers merged 3 commits into from
May 17, 2022

Conversation

@IAlibay
Copy link
Member

@IAlibay IAlibay commented May 17, 2022 •
edited
Loading

Fixes #54
Partly addresses #43
Towards #57

Description

Fix CI

  • Add conftest for FEMap creation of example.csv
  • Remove unused test file and replaced with quick import test

Fix badges

  • Add zenodo badge
  • Add CI badge
  • Fix coverage badge (needs checking once codecov runs)

Others

  • Remove erroneously introduced __init__.py~ file.

Todos

Notable points that this PR has either accomplished or will accomplish.

  • Clean up CI yaml file
    • Concurrency
    • Python matrix
    • Modernise mambaforge stuff
    • Update action versions
  • Check badges work
  • TBD

Status

  • Ready to go

@pep8speaks
Copy link

pep8speaks commented May 17, 2022 •
edited
Loading

Hello @IAlibay! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-05-17 13:13:37 UTC

@IAlibay IAlibay mentioned this pull request May 17, 2022
Open
@codecov
Copy link

codecov bot commented May 17, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@6c1faae). Click here to learn what that means.
The diff coverage is n/a.

@IAlibay IAlibay mentioned this pull request May 17, 2022
Open
@richardjgowers richardjgowers merged commit ca3fc2b into main May 17, 2022
@richardjgowers richardjgowers deleted the badges branch May 17, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@richardjgowers richardjgowers richardjgowers approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix badges

4 participants

@IAlibay @pep8speaks @richardjgowers