Skip to content

Conversation

@ijpulidos
Copy link
Contributor

These set of changes implement a test case for a short run of a protein-ligand complex (tyk2 and two of its ligands). The aim is to test protocol creation with different components (we have been testing only small mol components so far).

At the same time, a performance improvement on the creation of the hybrid topology was implemented, avoiding generating atoms lists, but instead generating them once and re-using the created list object.

@ijpulidos ijpulidos added this to the 0.1.1 milestone Aug 14, 2024
@ijpulidos
Copy link
Contributor Author

ijpulidos commented Aug 14, 2024

We are now running the tests in ~5.5 minutes. In contrast to ~13.5 minutes before these changes. 🚀

I marked the protein-ligand complex test as "slow" for now (that means it's getting skipped, it takes about 20 mins to run). Probably something to review once we have the self-hosted GPU CI working here (issue #21). This one should be ready to review.

@ijpulidos ijpulidos marked this pull request as ready for review August 14, 2024 23:46
@ijpulidos ijpulidos requested review from dotsdl and mikemhenry August 14, 2024 23:47
Copy link
Contributor

@mikemhenry mikemhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ijpulidos ijpulidos merged commit b3f230a into main Aug 19, 2024
@ijpulidos ijpulidos deleted the add-complex-testing branch August 19, 2024 17:04
@IAlibay IAlibay mentioned this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants