Skip to content

Conversation

@IAlibay
Copy link
Member

@IAlibay IAlibay commented Nov 7, 2024

Fixes #1004 #1003

Developers certificate of origin

@IAlibay IAlibay requested a review from atravitz November 7, 2024 16:32
@codecov
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.84%. Comparing base (5173b30) to head (c5adc20).
Report is 201 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1005      +/-   ##
==========================================
+ Coverage   91.64%   92.84%   +1.20%     
==========================================
  Files         134      134              
  Lines        9935     9940       +5     
==========================================
+ Hits         9105     9229     +124     
+ Misses        830      711     -119     
Flag Coverage Δ
fast-tests 92.84% <100.00%> (+1.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IAlibay IAlibay added this to the 1.1.1 milestone Nov 7, 2024
Copy link
Contributor

@mikemhenry mikemhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atravitz atravitz merged commit ab9a78a into main Nov 7, 2024
@atravitz atravitz deleted the fix-1004 branch November 7, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix key stability tests in line with gufe 1.1.0 release

4 participants