Skip to content

Conversation

@atravitz
Copy link
Contributor

@atravitz atravitz commented Nov 7, 2024

Developers certificate of origin

@atravitz atravitz linked an issue Nov 7, 2024 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.84%. Comparing base (d24c6a7) to head (dfdb32d).
Report is 197 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1007      +/-   ##
==========================================
- Coverage   94.59%   92.84%   -1.76%     
==========================================
  Files         134      134              
  Lines        9940     9940              
==========================================
- Hits         9403     9229     -174     
- Misses        537      711     +174     
Flag Coverage Δ
fast-tests 92.84% <ø> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atravitz atravitz requested a review from mikemhenry November 7, 2024 23:30
Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about adding the conda lock and single file installers to the release assets?

@mikemhenry
Copy link
Contributor

That step happens after the conda-forge build is done/uploaded. Adding the assets is automated now 😎 but still requires a manual click to fire off (for now, we could automate it as well). So something like "After the conda-forge package is uploaded, start single file installer and docker image workflow (and verify it was successful)"

@atravitz
Copy link
Contributor Author

I updated this to point to the wiki for all post-merge items. I think things are clearer this way. @mikemhenry ready for another look/approval. We will of course improve this during our next release process.

Co-authored-by: Irfan Alibay <IAlibay@users.noreply.github.com>
Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@atravitz atravitz merged commit b6075e6 into main Nov 12, 2024
9 checks passed
@atravitz atravitz deleted the 623-create-release-checklist branch November 12, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create release checklist

4 participants