Skip to content

Conversation

@atravitz
Copy link
Contributor

@atravitz atravitz commented Nov 8, 2024

I think it's good practice to keep READMEs toward the top of the directory structure.

@atravitz atravitz requested a review from mikemhenry November 8, 2024 18:55
@codecov
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.84%. Comparing base (ab76a57) to head (9e91118).
Report is 198 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1009      +/-   ##
==========================================
- Coverage   94.59%   92.84%   -1.76%     
==========================================
  Files         134      134              
  Lines        9940     9940              
==========================================
- Hits         9403     9229     -174     
- Misses        537      711     +174     
Flag Coverage Δ
fast-tests 92.84% <ø> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see why it was there, and I agree with the move.

Should we open an issue to discuss if we should move it to the sphinx docs?

Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meant to approve sorry

@atravitz
Copy link
Contributor Author

atravitz commented Nov 8, 2024

I can see why it was there, and I agree with the move.

Should we open an issue to discuss if we should move it to the sphinx docs?

I don't think it should live in sphinx docs yet, I want to make sure it's more external-user-friendly first.

@atravitz atravitz merged commit d24c6a7 into main Nov 8, 2024
@atravitz atravitz deleted the make_cli_readme_findable branch November 8, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants