-
Notifications
You must be signed in to change notification settings - Fork 35
create test data for quickrun submitted in parallel #1040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🚨 API breaking changes detected! 🚨 |
1 similar comment
|
🚨 API breaking changes detected! 🚨 |
7ee21d2 to
cf463cb
Compare
|
🚨 API breaking changes detected! 🚨 |
2 similar comments
|
🚨 API breaking changes detected! 🚨 |
|
🚨 API breaking changes detected! 🚨 |
|
🚨 API breaking changes detected! 🚨 |
|
@atravitz can you confirm that you loaded these back into ProtocolResults objects and it reads fine? |
|
🚨 API breaking changes detected! 🚨 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1040 +/- ##
==========================================
- Coverage 94.58% 92.79% -1.79%
==========================================
Files 134 134
Lines 9973 9980 +7
==========================================
- Hits 9433 9261 -172
- Misses 540 719 +179
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
IAlibay
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the one thing, otherwise - if it loads back up properly - then it looks good to me.
jthorton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Both the |
This reverts commit 6ae5d1d.
8674a56 to
dfb6d73
Compare
|
🚨 API breaking changes detected! 🚨 |
I re-arranged the data in
openfecli/test/data/resultsto mimic the results from aquickrunsubmission where every replicate is separate. I'll use this dataset to test the solution to this issueI included the notebook I used to generate this data since I expect we might want to use it again in the future. It's not polished, but I think it's good to have some record of where this test data came from.