Skip to content

Conversation

@jthorton
Copy link
Collaborator

@jthorton jthorton commented Dec 12, 2024

Fixes #1037 by making the edge scores deterministic, this should ensure we always get the same networks regardless of edge ordering.
Checklist

  • Added a news entry

Developers certificate of origin

@github-actions
Copy link

🚨 API breaking changes detected! 🚨

@jthorton jthorton requested review from IAlibay and atravitz December 12, 2024 10:46
@codecov
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.79%. Comparing base (5e198a1) to head (fe8c75d).
Report is 157 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1046      +/-   ##
==========================================
- Coverage   94.54%   92.79%   -1.75%     
==========================================
  Files         134      134              
  Lines        9982     9984       +2     
==========================================
- Hits         9437     9265     -172     
- Misses        545      719     +174     
Flag Coverage Δ
fast-tests 92.79% <100.00%> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually backing out a litlte bit - isn't this also likely to have clashes because they all have the same score? I.e. it's still sort dependent?

@jthorton
Copy link
Collaborator Author

There should only be a single possible MST with these new edge scores regardless of the graph's ordering though where as the current failures are due to multiple possible MST networks and the returned one is selected based on the ordering of the edges. We also seem to get the same network on main and on the last working commit on gufe so hopefully that shows its not order dependent.

Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation - lgtm.

@jthorton jthorton merged commit 7c67064 into main Dec 12, 2024
12 of 13 checks passed
@jthorton jthorton deleted the regression_test_fix branch December 12, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix test_network_planning regression tests

3 participants