-
Notifications
You must be signed in to change notification settings - Fork 35
Test cofactor networks generated with the CLI #1048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🚨 API breaking changes detected! 🚨 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1048 +/- ##
==========================================
- Coverage 94.46% 92.74% -1.72%
==========================================
Files 135 135
Lines 10077 10093 +16
==========================================
- Hits 9519 9361 -158
- Misses 558 732 +174
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Python 3.11/12 tests are failing as the name of the cofactor component is not what we expect, see here.
|
|
🚨 API breaking changes detected! 🚨 |
|
🚨 API breaking changes detected! 🚨 |
atravitz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one change to make the enum handling cleaner.
|
No API break detected ✅ |
Extend the CLI network tests with cofactors to explicitly check that they are included in the transformations.
Checklist
newsentryDevelopers certificate of origin