-
Notifications
You must be signed in to change notification settings - Fork 35
Support outdir created at runtime #1072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1072 +/- ##
==========================================
- Coverage 94.47% 92.74% -1.73%
==========================================
Files 135 135
Lines 10092 10090 -2
==========================================
- Hits 9534 9358 -176
- Misses 558 732 +174
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Edit: sorry changed my mind!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this does fix a bug, can you add a change log entry saying that the bug is fixed?
And delete the changelog entry that contradicts the behavior implemented in this PR?
|
No API break detected ✅ |
mikemhenry
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM -- Thanks!
* adding test * create directories * fixing a word * update news * update news
Resolves #986 (comment)
Checklist
newsentryDevelopers certificate of origin