Skip to content

Conversation

@atravitz
Copy link
Contributor

@atravitz atravitz commented Jan 9, 2025

Resolves #986 (comment)

Checklist

  • Added a news entry

Developers certificate of origin

@atravitz atravitz requested a review from mikemhenry January 9, 2025 23:58
@atravitz atravitz marked this pull request as ready for review January 10, 2025 00:04
@codecov
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.74%. Comparing base (2eb0ec8) to head (29bb619).
Report is 143 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1072      +/-   ##
==========================================
- Coverage   94.47%   92.74%   -1.73%     
==========================================
  Files         135      135              
  Lines       10092    10090       -2     
==========================================
- Hits         9534     9358     -176     
- Misses        558      732     +174     
Flag Coverage Δ
fast-tests 92.74% <100.00%> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@mikemhenry mikemhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Edit: sorry changed my mind!

@mikemhenry mikemhenry self-requested a review January 14, 2025 15:33
Copy link
Contributor

@mikemhenry mikemhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this does fix a bug, can you add a change log entry saying that the bug is fixed?
And delete the changelog entry that contradicts the behavior implemented in this PR?

@github-actions
Copy link

No API break detected ✅

@atravitz atravitz requested a review from mikemhenry January 14, 2025 16:39
Copy link
Contributor

@mikemhenry mikemhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- Thanks!

@mikemhenry mikemhenry enabled auto-merge (squash) January 14, 2025 16:40
@mikemhenry mikemhenry merged commit 915d110 into main Jan 14, 2025
12 checks passed
@mikemhenry mikemhenry deleted the support_outdir_created_at_runtime branch January 14, 2025 16:50
atravitz added a commit that referenced this pull request Jan 15, 2025
* adding test

* create directories

* fixing a word

* update news

* update news
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

input validation for directory/json names

3 participants