gather - show all failed edges in error message #1095
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1095 +/- ##
==========================================
- Coverage 93.56% 91.82% -1.74%
==========================================
Files 137 137
Lines 10105 10096 -9
==========================================
- Hits 9455 9271 -184
- Misses 650 825 +175
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
atravitz
force-pushed
the
output_all_failed_edges
branch
2 times, most recently
from
74e558b to
bfe911e
Compare
atravitz
changed the title
IAlibay
requested changes
Jan 28, 2025
Member
IAlibay
left a comment
IAlibay
left a comment
There was a problem hiding this comment.
This looks fine to me, but the error message seems like it might be a bit too unweildy.
Ideally we want something that's easy to parse for edges rather than a lot of text around each printed line.
atravitz
force-pushed
the
output_all_failed_edges
branch
from
fec49d6 to
cae75d1
Compare
atravitz
force-pushed
the
output_all_failed_edges
branch
from
cae75d1 to
f6c9ef8
Compare
jthorton
approved these changes
Jan 30, 2025
Collaborator
jthorton
left a comment
jthorton
left a comment
There was a problem hiding this comment.
One not blocking suggestion for info on restarting, otherwise this is great!
|
No API break detected ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1101
Checklist
newsentryDevelopers certificate of origin