Skip to content

Conversation

@atravitz
Copy link
Contributor

@atravitz atravitz commented Jan 30, 2025

gufe PRS OpenFreeEnergy/gufe#468 and OpenFreeEnergy/gufe#467 cause tests to break on the openfe side.

@jthorton - could you confirm that this change to the tyk2 output is what you expect?

possible breaking gufe commits:

Developers certificate of origin

@atravitz atravitz requested a review from jthorton January 30, 2025 20:59
@atravitz atravitz self-assigned this Jan 30, 2025
@atravitz atravitz marked this pull request as draft January 30, 2025 21:44
@jthorton
Copy link
Collaborator

@atravitz thanks for taking this, and yes I expect different edges for the tyk2 network now, let hope this is the last time we have to fix this for a while!

@atravitz atravitz added this to the v1.4.0 milestone Jan 31, 2025
@atravitz atravitz force-pushed the fix_inchikey_sorting_breaks branch from af90d05 to 31d4365 Compare March 3, 2025 20:37
@github-actions
Copy link

github-actions bot commented Mar 3, 2025

No API break detected ✅

@atravitz atravitz marked this pull request as ready for review March 3, 2025 21:55
@codecov
Copy link

codecov bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.89%. Comparing base (c72085a) to head (1463b38).
Report is 98 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1107      +/-   ##
==========================================
- Coverage   93.52%   91.89%   -1.64%     
==========================================
  Files         142      142              
  Lines       10628    10636       +8     
==========================================
- Hits         9940     9774     -166     
- Misses        688      862     +174     
Flag Coverage Δ
fast-tests 91.89% <100.00%> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@jthorton jthorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@atravitz atravitz merged commit 984ba90 into main Mar 4, 2025
13 checks passed
@atravitz atravitz deleted the fix_inchikey_sorting_breaks branch March 4, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants