-
Notifications
You must be signed in to change notification settings - Fork 35
Fix breaking tests from gufe updates #1107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@atravitz thanks for taking this, and yes I expect different edges for the tyk2 network now, let hope this is the last time we have to fix this for a while! |
…ikey_sorting_breaks
This reverts commit 93e4f05.
af90d05 to
31d4365
Compare
|
No API break detected ✅ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1107 +/- ##
==========================================
- Coverage 93.52% 91.89% -1.64%
==========================================
Files 142 142
Lines 10628 10636 +8
==========================================
- Hits 9940 9774 -166
- Misses 688 862 +174
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jthorton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
gufe PRS OpenFreeEnergy/gufe#468 and OpenFreeEnergy/gufe#467 cause tests to break on the openfe side.
@jthorton - could you confirm that this change to the tyk2 output is what you expect?
possible breaking gufe commits:
Developers certificate of origin