Skip to content

Conversation

@mikemhenry
Copy link
Contributor

@mikemhenry mikemhenry commented Jan 30, 2025

Checklist

  • Added a news entry

Developers certificate of origin

@mikemhenry
Copy link
Contributor Author

@jthorton Do we have to turn anything on to test the perses atom mapper?

@mikemhenry
Copy link
Contributor Author

The build shows up here: https://anaconda.org/conda-forge/perses/files
CDN might need some time to pick up the new build

@mikemhenry
Copy link
Contributor Author

Also might need to clear the cache, but even locally that build isn't showing up for me, I will just bump this tomorrow and see if that fixes it

@IAlibay IAlibay closed this Jan 31, 2025
@IAlibay IAlibay reopened this Jan 31, 2025
@IAlibay
Copy link
Member

IAlibay commented Jan 31, 2025

Cycling to see if we're picking up the new perses

@IAlibay
Copy link
Member

IAlibay commented Jan 31, 2025

Do we have to turn anything on to test the perses atom mapper?

Should just work as is 🤞🏽

@IAlibay
Copy link
Member

IAlibay commented Jan 31, 2025

Amazing, the environment resolves!

Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocking, there seems to be some concerning failures.

@codecov
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.84%. Comparing base (1c2d40d) to head (d6bb946).
Report is 118 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1108      +/-   ##
==========================================
+ Coverage   90.75%   91.84%   +1.08%     
==========================================
  Files         142      142              
  Lines       10528    10528              
==========================================
+ Hits         9555     9669     +114     
+ Misses        973      859     -114     
Flag Coverage Δ
fast-tests 91.84% <ø> (+1.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

No API break detected ✅

@IAlibay IAlibay changed the title Add perses back in for testing Add perses back in for testing, pin gufe, and fix bootstrap tests Jan 31, 2025
Copy link
Collaborator

@jthorton jthorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@atravitz atravitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! just one non-blocking comment

@atravitz atravitz merged commit cb7d8d5 into main Jan 31, 2025
12 checks passed
@atravitz atravitz deleted the test-perses branch January 31, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants