-
Notifications
You must be signed in to change notification settings - Fork 35
Add perses back in for testing, pin gufe, and fix bootstrap tests #1108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@jthorton Do we have to turn anything on to test the perses atom mapper? |
|
The build shows up here: https://anaconda.org/conda-forge/perses/files |
|
Also might need to clear the cache, but even locally that build isn't showing up for me, I will just bump this tomorrow and see if that fixes it |
|
Cycling to see if we're picking up the new perses |
Should just work as is 🤞🏽 |
|
Amazing, the environment resolves! |
IAlibay
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blocking, there seems to be some concerning failures.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1108 +/- ##
==========================================
+ Coverage 90.75% 91.84% +1.08%
==========================================
Files 142 142
Lines 10528 10528
==========================================
+ Hits 9555 9669 +114
+ Misses 973 859 -114
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
No API break detected ✅ |
jthorton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
atravitz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! just one non-blocking comment
Checklist
newsentryDevelopers certificate of origin