Skip to content

Conversation

@IAlibay
Copy link
Member

@IAlibay IAlibay commented Feb 3, 2025

Changes the datatype for storing time to float, and adapts test to pass for new upstream fix.

Developers certificate of origin

@IAlibay IAlibay marked this pull request as ready for review February 3, 2025 20:23
@IAlibay IAlibay requested a review from atravitz February 3, 2025 20:23
@github-actions
Copy link

github-actions bot commented Feb 3, 2025

No API break detected ✅

@codecov
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.84%. Comparing base (1c2d40d) to head (8c1704c).
Report is 118 commits behind head on main.

Files with missing lines Patch % Lines
openfe/tests/protocols/test_openmm_rfe_slow.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1114      +/-   ##
==========================================
+ Coverage   90.75%   91.84%   +1.08%     
==========================================
  Files         142      142              
  Lines       10528    10527       -1     
==========================================
+ Hits         9555     9668     +113     
+ Misses        973      859     -114     
Flag Coverage Δ
fast-tests 91.84% <0.00%> (+1.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@atravitz atravitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@IAlibay
Copy link
Member Author

IAlibay commented Feb 3, 2025

Thanks @atravitz - I'll go ahead with the merge so I can update the other branch.

@IAlibay IAlibay merged commit bd95f22 into main Feb 3, 2025
11 of 12 checks passed
@IAlibay IAlibay deleted the fix-multistate_analysis branch February 3, 2025 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants