Skip to content

Conversation

@atravitz
Copy link
Contributor

@atravitz atravitz commented Feb 17, 2025

@mikemhenry let me know if this is helpful

Checklist

  • Added a news entry

Developers certificate of origin

@atravitz atravitz requested a review from mikemhenry February 17, 2025 17:05
@atravitz atravitz self-assigned this Feb 17, 2025
@mikemhenry
Copy link
Contributor

Yes I like it! I think we should look into how we want logging to work and what gets the privilege of writing to std out, but since network planning tends to be interactive/very human in the loop, I think stuff like this is nice to have!

@codecov
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.89%. Comparing base (ebb3a7e) to head (1d96be2).
Report is 85 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1137      +/-   ##
==========================================
- Coverage   93.52%   91.89%   -1.64%     
==========================================
  Files         142      142              
  Lines       10633    10635       +2     
==========================================
- Hits         9945     9773     -172     
- Misses        688      862     +174     
Flag Coverage Δ
fast-tests 91.89% <100.00%> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"request changes" for wording update, please discard review after change (i.e. this doesn't need a re-review).

@github-actions
Copy link

No API break detected ✅

@atravitz atravitz enabled auto-merge (squash) February 18, 2025 20:29
@atravitz atravitz disabled auto-merge February 18, 2025 20:35
@atravitz atravitz enabled auto-merge (squash) February 18, 2025 20:35
@atravitz atravitz disabled auto-merge February 18, 2025 20:35
@atravitz atravitz merged commit 829ce37 into main Feb 18, 2025
13 checks passed
@atravitz atravitz deleted the add_user_message_for_n_protocol_repeats branch February 18, 2025 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants