Skip to content

Conversation

@atravitz
Copy link
Contributor

@atravitz atravitz commented Feb 20, 2025

since @mikemhenry and I decided that 1MB is our cap for file sizes, it's fine for us to commit the cdk8 dataset as-is.

resolves #1078

Developers certificate of origin

@atravitz atravitz requested a review from mikemhenry February 20, 2025 17:11
@atravitz atravitz self-assigned this Feb 20, 2025
Copy link
Contributor

@mikemhenry mikemhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atravitz atravitz marked this pull request as draft February 20, 2025 17:16
Copy link
Contributor

@mikemhenry mikemhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh can you update the manifest?

@codecov
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.89%. Comparing base (244e2f9) to head (f780e0b).
Report is 83 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1151      +/-   ##
==========================================
- Coverage   93.53%   91.89%   -1.64%     
==========================================
  Files         142      142              
  Lines       10635    10633       -2     
==========================================
- Hits         9947     9771     -176     
- Misses        688      862     +174     
Flag Coverage Δ
fast-tests 91.89% <100.00%> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@atravitz atravitz marked this pull request as ready for review February 20, 2025 18:05
@mikemhenry mikemhenry self-requested a review February 20, 2025 18:11
Copy link
Contributor

@mikemhenry mikemhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikemhenry mikemhenry enabled auto-merge (squash) February 20, 2025 18:12
@atravitz atravitz disabled auto-merge February 20, 2025 18:34
@github-actions
Copy link

No API break detected ✅

@atravitz atravitz merged commit d042738 into main Feb 20, 2025
13 checks passed
@atravitz atravitz deleted the fix_cdk8_dataset branch February 20, 2025 21:57
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last year, the team made a decision to try to gzip all PDB files going forward. Doing so here would be easy / low cost, can we try to do this too?

@IAlibay
Copy link
Member

IAlibay commented Feb 23, 2025

decided that 1MB is our cap for file sizes

Can we possibly discuss this more? It runs somewhat against things we previously agreed upon as a team. I can see the reason for this decision, but I suspect there's context to the "floodgates" this migth open if unrestricted. If anything, the minimum here is that the whole team should be aware of what the current file upload standards are (it's something we hit on quite often during Protocol development).

@IAlibay
Copy link
Member

IAlibay commented Feb 23, 2025

It runs somewhat against things we previously agreed upon as a team

Here I mean the above-mentioned "gzipping PDB files where we can", approach.

@mikemhenry
Copy link
Contributor

Yes of course -- we are talking about 630K difference:

864K	cdk8
216K	cdk8.zip

We should probably add some tooling then to make it easy to pack and unpack test data if we want to treat it as a big tarball hosted somewhere else, or even if we decide to keep them in out git repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

improve handling of zipped test data

4 participants