Skip to content

Conversation

@IAlibay
Copy link
Member

@IAlibay IAlibay commented Feb 26, 2025

Fixes #1164

Developers certificate of origin

@github-actions
Copy link

No API break detected ✅

@IAlibay IAlibay requested a review from jthorton February 26, 2025 11:29
@codecov
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.88%. Comparing base (91724bc) to head (3ef6b42).
Report is 88 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1165      +/-   ##
==========================================
- Coverage   93.52%   91.88%   -1.64%     
==========================================
  Files         142      142              
  Lines       10628    10628              
==========================================
- Hits         9940     9766     -174     
- Misses        688      862     +174     
Flag Coverage Δ
fast-tests 91.88% <100.00%> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@ianmkenney ianmkenney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikemhenry
Copy link
Contributor

brings me back to the python 2.7 days when using / and ints you want to be floats was going to be a bad time

@mikemhenry mikemhenry merged commit ddb679b into main Feb 26, 2025
13 checks passed
@mikemhenry mikemhenry deleted the fix_1164 branch February 26, 2025 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix default value for MultiStateOutputSettings.positions_write_frequency

4 participants