Temporary solution for #1173 #1174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atravitz
changed the title
IAlibay
changed the title
hannahbaumann
approved these changes
Mar 7, 2025
Contributor
hannahbaumann
left a comment
hannahbaumann
left a comment
There was a problem hiding this comment.
Thanks @IAlibay , lgtm!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1174 +/- ##
==========================================
- Coverage 94.14% 92.49% -1.65%
==========================================
Files 141 141
Lines 10567 10570 +3
==========================================
- Hits 9948 9777 -171
- Misses 619 793 +174
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
IAlibay
commented
Mar 10, 2025
Member
Author
There was a problem hiding this comment.
TODO: need to update docs to state that forward reverse is not bootstrap errors.
|
No API break detected ✅ |
jthorton
approved these changes
Mar 10, 2025
Collaborator
jthorton
left a comment
jthorton
left a comment
There was a problem hiding this comment.
Nice this should do for now, docs look good as well!
Contributor
|
This looks good to me too, also with the docs! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exact number here is unclear (and will depend case-by-case), but it at least gets rid of the worst cases.
Checklist
newsentryDevelopers certificate of origin