Skip to content

Conversation

@mikemhenry
Copy link
Contributor

Checklist

  • Added a news entry

Developers certificate of origin

@mikemhenry mikemhenry requested review from IAlibay and atravitz March 7, 2025 16:09
@codecov
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.49%. Comparing base (51da376) to head (fc33b0b).
Report is 100 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1183      +/-   ##
==========================================
- Coverage   94.14%   92.49%   -1.65%     
==========================================
  Files         141      141              
  Lines       10567    10567              
==========================================
- Hits         9948     9774     -174     
- Misses        619      793     +174     
Flag Coverage Δ
fast-tests 92.49% <ø> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without the extra force we're good. Will need to pin interchange in places that directly use it (outside of SystemGenerator).

@IAlibay IAlibay enabled auto-merge March 7, 2025 17:01
@github-actions
Copy link

github-actions bot commented Mar 7, 2025

No API break detected ✅

@mikemhenry
Copy link
Contributor Author

image
not sure why that one required check is pending when it looks like the check came in (see bottom of screenshot)

@IAlibay IAlibay merged commit 9732960 into main Mar 7, 2025
13 checks passed
@IAlibay IAlibay deleted the relax-interchange-pin branch March 7, 2025 23:12
@mikemhenry
Copy link
Contributor Author

lol I think I just fixed it but it got merged in before I could check 😄

@mikemhenry
Copy link
Contributor Author

Oh it was on auto merge!! Okay so I did fix it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants