Skip to content

Conversation

@mikemhenry
Copy link
Contributor

@mikemhenry mikemhenry commented Mar 10, 2025

Checklist

  • Added a news entry

Developers certificate of origin

Fixes #1178

@codecov
Copy link

codecov bot commented Mar 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.51%. Comparing base (384d9cc) to head (2769f90).
Report is 88 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1186      +/-   ##
==========================================
- Coverage   94.14%   92.51%   -1.64%     
==========================================
  Files         141      141              
  Lines       10570    10588      +18     
==========================================
- Hits         9951     9795     -156     
- Misses        619      793     +174     
Flag Coverage Δ
fast-tests 92.51% <100.00%> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mikemhenry
Copy link
Contributor Author

This will be tricky to mock:
image

@mikemhenry
Copy link
Contributor Author

I was wrong, it was quite mockable

@mikemhenry
Copy link
Contributor Author

wooo 100% diff coverage

@mikemhenry mikemhenry marked this pull request as ready for review March 10, 2025 23:32
@mikemhenry mikemhenry requested review from IAlibay and atravitz March 10, 2025 23:32
@mikemhenry mikemhenry mentioned this pull request Mar 10, 2025
@github-actions
Copy link

No API break detected ✅

@mikemhenry mikemhenry merged commit c5d0e58 into main Mar 12, 2025
13 checks passed
@mikemhenry mikemhenry deleted the make_get_gpu_info_more_robust branch March 12, 2025 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

System probe fails if nvidia-smi is available but it doesn't detect GPU

4 participants