Skip to content

Conversation

@mikemhenry
Copy link
Contributor

@mikemhenry mikemhenry commented Mar 14, 2025

Checklist

  • Added a news entry

Developers certificate of origin

Same as OpenFreeEnergy/gufe#511

These deps don't really help anyone install or test the package and just get in the way of tooling

@github-actions
Copy link

No API break detected ✅

@mikemhenry
Copy link
Contributor Author

The docs might break since they do use pyproject.toml to install deps if they are listed, but this could actually speed up the build since locally when I created the env for the docs, I only used the yaml, but RTD uses the yaml + the pyproject.toml

@mikemhenry mikemhenry requested a review from atravitz March 14, 2025 19:18
@codecov
Copy link

codecov bot commented Mar 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.51%. Comparing base (31bb2a7) to head (5c7680b).
Report is 95 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1191      +/-   ##
==========================================
- Coverage   94.15%   92.51%   -1.65%     
==========================================
  Files         141      141              
  Lines       10588    10588              
==========================================
- Hits         9969     9795     -174     
- Misses        619      793     +174     
Flag Coverage Δ
fast-tests 92.51% <ø> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mikemhenry
Copy link
Contributor Author

looks like that didn't break anything!

@atravitz atravitz merged commit 651a574 into main Mar 14, 2025
13 checks passed
@atravitz atravitz deleted the feat/remove-deps branch March 14, 2025 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants