Skip to content

Conversation

@atravitz
Copy link
Contributor

@atravitz atravitz commented Mar 24, 2025

Checklist

  • Added a news entry

Developers certificate of origin

@codecov
Copy link

codecov bot commented Mar 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.57%. Comparing base (35aa3aa) to head (07c5da2).
Report is 98 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1208      +/-   ##
==========================================
- Coverage   94.20%   92.57%   -1.64%     
==========================================
  Files         141      141              
  Lines       10668    10669       +1     
==========================================
- Hits        10050     9877     -173     
- Misses        618      792     +174     
Flag Coverage Δ
fast-tests 92.57% <100.00%> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@atravitz atravitz requested a review from hannahbaumann March 25, 2025 19:38
@atravitz atravitz marked this pull request as ready for review March 25, 2025 19:39
@atravitz atravitz added this to the v1.3.1 milestone Mar 25, 2025
@atravitz atravitz self-assigned this Mar 25, 2025
Copy link
Contributor

@mikemhenry mikemhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- one idea that is non-blocking, a test that has and doesn't have the allow_partial flag and we assert the error is raised and the warning is raised, depending on the case

@atravitz atravitz force-pushed the cleanup_allow_partial_msg branch from ca74cb0 to 431c64c Compare March 27, 2025 14:19
@atravitz atravitz requested a review from mikemhenry March 27, 2025 19:45
@atravitz
Copy link
Contributor Author

LGTM -- one idea that is non-blocking, a test that has and doesn't have the allow_partial flag and we assert the error is raised and the warning is raised, depending on the case

good idea - a check already exists for the error, but I added a pytest.warns(match) for good measure

@github-actions
Copy link

No API break detected ✅

@atravitz atravitz merged commit cd219bc into main Mar 27, 2025
13 checks passed
@atravitz atravitz deleted the cleanup_allow_partial_msg branch March 27, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants