pooch - add triplicate retries #1213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1213 +/- ##
==========================================
- Coverage 94.20% 92.57% -1.64%
==========================================
Files 141 141
Lines 10659 10662 +3
==========================================
- Hits 10041 9870 -171
- Misses 618 792 +174
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
No API break detected ✅ |
atravitz
commented
Mar 26, 2025
Comment on lines
+11
to
+24
| import openfe | ||
| import pooch | ||
| import pytest | ||
| from gufe.settings import OpenMMSystemGeneratorFFSettings, ThermoSettings | ||
| from numpy.testing import assert_allclose, assert_equal | ||
| from openfe.protocols.openmm_rfe.equil_rfe_settings import ( | ||
| IntegratorSettings, OpenMMSolvationSettings) | ||
| from openfe.protocols.openmm_utils import (charge_generation, | ||
| multistate_analysis, omm_settings, | ||
| settings_validation, | ||
| system_creation, system_validation) | ||
| from openfe.protocols.openmm_utils.charge_generation import (HAS_ESPALOMA, | ||
| HAS_NAGL, | ||
| HAS_OPENEYE) |
Contributor
Author
There was a problem hiding this comment.
this is just me applying isort to this file bc there were many imports
mikemhenry
approved these changes
Mar 26, 2025
Comment on lines
+11
to
+24
| import openfe | ||
| import pooch | ||
| import pytest | ||
| from gufe.settings import OpenMMSystemGeneratorFFSettings, ThermoSettings | ||
| from numpy.testing import assert_allclose, assert_equal | ||
| from openfe.protocols.openmm_rfe.equil_rfe_settings import ( | ||
| IntegratorSettings, OpenMMSolvationSettings) | ||
| from openfe.protocols.openmm_utils import (charge_generation, | ||
| multistate_analysis, omm_settings, | ||
| settings_validation, | ||
| system_creation, system_validation) | ||
| from openfe.protocols.openmm_utils.charge_generation import (HAS_ESPALOMA, | ||
| HAS_NAGL, | ||
| HAS_OPENEYE) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently seeing our CI fail on pooch retrievals from figshare. We're guessing this is a "too many requests" issue, but we should be retrying as a best practice regardless.
Checklist
newsentryDevelopers certificate of origin